fix data access issues

NASA_OSDR.py

@@ -97,26 +97,37 @@ class NasaOsdr(datasets.GeneratorBasedBuilder):
             citation=_CITATION,
         )
 
+    _URL = "https://raw.githubusercontent.com/AnzorGozalishvili/NASA_ODSR_DATA/main"
+    _ASSAYS_FILE = "assays.csv"
+    _SAMPLES_FILE = "samples.csv"
+
     def _split_generators(self, dl_manager):
-        # no need to download, dataset is there!
-        # dataset_root = dl_manager.download_and_extract(_FIFTYONE_DATASET_URL)
+        downloaded_files = dl_manager.download_and_extract(
+            {
+                "train": {
+                    "assays": os.path.join(self._URL, self._ASSAYS_FILE),
+                    "samples": os.path.join(self._URL, self._ASSAYS_FILE)
+                },
+            }
+        )
+
         return [
             datasets.SplitGenerator(
                 name=datasets.Split.TRAIN,
                 gen_kwargs={
-                    "split": "train",
-                    "dataset_root": "data",
+                    "assays_file": downloaded_files['train']['assays'],
+                    "samples_file": downloaded_files['train']['samples'],
                 },
             ),
         ]
 
-    def _generate_examples(self, split: str, dataset_root: str):
-        assays = os.path.join(dataset_root, "assays.csv")
-        samples = os.path.join(dataset_root, "samples.csv")
+    def _generate_examples(self, assays_file: str, samples_file):
+        # assays = os.path.join(dataset_root, "assays.csv")
+        # samples = os.path.join(dataset_root, "samples.csv")
         # there can be other metadata tables merged
 
-        assays_df = pd.read_csv(assays)
-        samples_df = pd.read_csv(samples)
+        assays_df = pd.read_csv(assays_file)
+        samples_df = pd.read_csv(samples_file)
 
         for (idx, assay_row), (_, sample_row) in zip(assays_df.iterrows(), samples_df.iterrows()):
             _item = {**assay_row.to_dict()}

tests/{test_iliauni_icc_georgian_ocr.py → test_nasa_osdr.py}

@@ -33,7 +33,7 @@ def test_inherit_generator_base_builder_works():
 
 def test_generate_examples():
     dataset = NasaOsdr()
-    train_data = dataset._generate_examples(dataset_root='data', split='train')
+    train_data = dataset._generate_examples(assays_file='data/assays.csv', samples_file='data/samples.csv')
     idx, sample = next(iter(train_data))
     print(idx, sample.keys())